Refactor test callbacks into TestInvoker class.#164
Merged
Conversation
rniwa
force-pushed
the
refactor-test-callbacks
branch
2 times, most recently
from
d15a210 to
509bff2
Compare
Member
Author
Safari 16.3Before After Chrome 113.0.5672.126Before After Firefox 113.0.1Before After |
smaug----
reviewed
May 23, 2023
tests/benchmark-runner-tests.mjs
Outdated
| describe("Test", () => { | ||
| describe("_runTestAndRecordResults", () => { | ||
| let _runTestSpy; | ||
| let peformanceMarkSpy; |
There was a problem hiding this comment.
performanceMarkSpy
(I know, the existing code has also peformance)
smaug----
approved these changes
May 23, 2023
rniwa
force-pushed
the
refactor-test-callbacks
branch
5 times, most recently
from
b506860 to
3e306f8
Compare
This class abstracts away two nested setTimeout calls and requestAnimationFrame.
rniwa
force-pushed
the
refactor-test-callbacks
branch
from
3e306f8 to
0f3f850
Compare
Member
Author
|
refactor-test-callback-results.zip Safari 16.4 (18615.1.26.11.23)Before After Firefox 113.0.2Before After Chrome 113.0.5672.126Before After |
flashdesignory
approved these changes
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This class abstracts away two nested setTimeout calls and requestAnimationFrame.