Merged
Conversation
This is another asm.js benchmark that we missed from before. Like float-mm.c, we don't think asm.js has enough in the wild usage to justify benchmarking.
Contributor
Author
|
#36 was the original PR for this but got messed up... |
Contributor
|
Removing asm.js SGTM. However, should we add a Wasm build of that as a replacement, to get some coverage for LZ77-style algorithms? The CI for Chrome is failing right now, but possibly an infra issue, unrelated to this PR. @camillobruni Could you take a look regarding CI? |
Contributor
|
I'll have a look in a moment... likely some accidentally serialized DOM object due to an error is causing issues here. |
Contributor
Author
|
Yeah, the CI seems to be broken unfortunately... I wouldn't be opposed to some compression algorithm in wasm. I'll add it to our ideas list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another asm.js benchmark that we missed from before. Like float-mm.c, we don't think asm.js has enough in the wild usage to justify benchmarking.