Move sqlite Wasm benchmark to first, worst, average scoring#30
Merged
kmiller68 merged 2 commits intoWebKit:mainfrom Jan 27, 2025
Merged
Move sqlite Wasm benchmark to first, worst, average scoring#30kmiller68 merged 2 commits intoWebKit:mainfrom
kmiller68 merged 2 commits intoWebKit:mainfrom
Conversation
Drive-by: remove unused polyfills, update sqlite source distribution, rebuild
b943b4a to
ebddd39
Compare
Contributor
Author
|
Rebased. @kmiller68 If you are fine with it, feel free to merge (Ryan gave his 👍 above). |
Contributor
|
Given the iterations are so long I wonder if we should change the workload for this? e.g. to a trace from a real sqlite database. Anyway, we can consider that in the future. |
Contributor
Author
|
If a single iteration is still too long, we can easily change the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drive-by: remove unused polyfills, update sqlite source distribution, rebuild.
This now takes about ~6s to run with 15 iterations. I don't want to go much lower with the iteration count, but we could lower
--sizeinargvfurther (seebenchmark.js) to speed up a single iteration. Currently, one iteration takes 300-400ms, so we are well above the threshold we set for ourselves.@kmiller68 @eqrion @jandem WDYT?