External arazzo - #1654
Conversation
Arazzo Parser v1
|
hi @daniellopera15 (and @jgaleotti ) |
|
@arcuri82 |
| <groupId>io.swagger.core.v3</groupId> | ||
| <artifactId>swagger-annotations</artifactId> | ||
| <version>${swagger.annotations.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
@daniellopera15 why are those dependencies removed here in core-parent?
There was a problem hiding this comment.
@arcuri82 I had to modify the dependencies because it was overwriting the Swagger version, causing the CI to fail.
I suppose this comment has something to do with it.
The parser currently has no limitations regarding the Swagger version. Does it look good as it is now, or where should I move the dependency?
| <groupId>com.graphql-java</groupId> | ||
| <artifactId>java-dataloader</artifactId> | ||
| <version>${java.dataloader}</version> | ||
| </dependency> |
There was a problem hiding this comment.
this shouldn't be here. why? dependencies conflicts shouldn't be handled by adding unrelated libraries (GraphQL in this case), but by library declaration order and pinned versions in the affected modules.
There was a problem hiding this comment.
I'm going to revert the POM to the original version. That was the dependency I cleaned up earlier, but I forgot to remove it from the parent.
|
@arcuri82 The change is ready for review |
2 participants
No description provided.