Updates header-default.php group block tagname to div to match markup

[Cheffheid]

Closes

Part of my notes on #WDSBT-23.

Link to test

Might need to test this locally. Lab probably isn't using the default header pattern anymore.

Description

Fixed an issue where the header default renders with a broken block out of the box.

The site header is already printed inside of a <header class="site-header wp-block-template-part">, so changing it to div seemed best.

Mobile & Desktop Screenshots/Recordings

Fixes this:

Added to documentation?

• 📜 README.md
• 📓 Confluence
• 🙅 No documentation needed

Added tests?

• 👍 Yes
• 🙅 No, because they aren't needed
• 🙋 No, because I need help

Testing Instructions

Add the theme to a new site, or reset the header pattern to the default, and confirm that it no longer shows up with invalid content in the editor out of the box.

---

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

• Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
• Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
• Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
• Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
• Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
• Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
• Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
• Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
• Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

[khleomix]

Thanks @Cheffheid I thought this was changed already 😅. Approved!!!