This repository has been archived by the owner on Feb 27, 2024. It is now read-only.
Rename useApollo to useWpApollo and move it to connector.js #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webdevstudios/nextjs-wordpress-starter/AC5RPMbwSXPtrurDs9Gsj5t7x384 |
ravewebdev
approved these changes
May 5, 2021
| */ | ||
| export function useWpApollo(pageProps) { | ||
| const state = pageProps[APOLLO_STATE_PROP_NAME] | ||
| // Use WP Apollo instance by default. |
There was a problem hiding this comment.
I'd suggest removing this comment line as the renaming makes it clear this is the WP Apollo instance.
gregrickaby
approved these changes
May 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #421
Description
This PR removes the circular dependency by moving
useApollo()fromlib/apolloConfig.jstolib/wordpress/connector.jsasuseWpApollo()