-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing onadvertisementreceived attribute on Bluetooth and BluetoothDevice #426
Comments
An |
reillyeon
changed the title
there's no onadvertisementreceived event handler attribute
Missing onadvertisementreceived attribute on Bluetooth and BluetoothDevice
Feb 4, 2019
reillyeon
added a commit
to reillyeon/web-bluetooth
that referenced
this issue
Feb 12, 2019
This event type was defined but the EventHandler attribute was missing from the BluetoothDevice interface. This change adds it to the BluetoothDeviceEventHandlers mixin so that it is also present on the Bluetooth interface for bubbled events. Fixes WebBluetoothCG#426.
reillyeon
added a commit
that referenced
this issue
Feb 12, 2019
This event type was defined but the EventHandler attribute was missing from the BluetoothDevice interface. This change adds it to the BluetoothDeviceEventHandlers mixin so that it is also present on the Bluetooth interface for bubbled events. Fixes #426.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While this specification mostly follows the advice in §3.3. Always add event handler attributes, I just found one case where it doesn't. (I offer no promises it's the only case, though.) The specification has an
advertisementreceived
event, but the target of this event doesn't appear to have anonadvertisementreceived
event handler attribute.In this specification that target appears to be the device object, although the Web Bluetooth Scanning spec seems to extend that to fire at
navigator.bluetooth
... so it should probably also extend this attribute to be on more objects.(I got here from w3ctag/design-reviews#333, though this issue isn't specific to the scanning spec so I'm filing it here.)
The text was updated successfully, but these errors were encountered: