Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing onadvertisementreceived attribute on Bluetooth and BluetoothDevice #426

Closed
dbaron opened this issue Feb 4, 2019 · 1 comment
Closed

Comments

@dbaron
Copy link

dbaron commented Feb 4, 2019

While this specification mostly follows the advice in §3.3. Always add event handler attributes, I just found one case where it doesn't. (I offer no promises it's the only case, though.) The specification has an advertisementreceived event, but the target of this event doesn't appear to have an onadvertisementreceived event handler attribute.

In this specification that target appears to be the device object, although the Web Bluetooth Scanning spec seems to extend that to fire at navigator.bluetooth... so it should probably also extend this attribute to be on more objects.

(I got here from w3ctag/design-reviews#333, though this issue isn't specific to the scanning spec so I'm filing it here.)

@reillyeon
Copy link
Contributor

An onadvertisementreceived attribute is needed on the Bluetooth object to support the scanning API and on the BluetoothDevice object to support the watchAdvertisements() method.

@reillyeon reillyeon changed the title there's no onadvertisementreceived event handler attribute Missing onadvertisementreceived attribute on Bluetooth and BluetoothDevice Feb 4, 2019
reillyeon added a commit to reillyeon/web-bluetooth that referenced this issue Feb 12, 2019
This event type was defined but the EventHandler attribute was missing
from the BluetoothDevice interface. This change adds it to the
BluetoothDeviceEventHandlers mixin so that it is also present on the
Bluetooth interface for bubbled events.

Fixes WebBluetoothCG#426.
reillyeon added a commit that referenced this issue Feb 12, 2019
This event type was defined but the EventHandler attribute was missing
from the BluetoothDevice interface. This change adds it to the
BluetoothDeviceEventHandlers mixin so that it is also present on the
Bluetooth interface for bubbled events.

Fixes #426.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants