-
Notifications
You must be signed in to change notification settings - Fork 168
2361 use new idl buffer prim finer scope #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
rtoy
wants to merge
19
commits into
WebAudio:main
from
rtoy:2361-use-new-idl-buffer-prim-finer-scope
Closed
2361 use new idl buffer prim finer scope #2368
rtoy
wants to merge
19
commits into
WebAudio:main
from
rtoy:2361-use-new-idl-buffer-prim-finer-scope
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates spec to use new Web IDL buffer primitives. The changes are marked as candidate corrections, but we use several correction amendments to make it easy to see what the new and old text will be. Using just one makes it super-hard to figure out what controls the text, and the text sometimes doesn't always clearly show what's deleted and what's inserted because the links are colored correctly, and struck-through text doesn't strike through links. (A bikeshed issue?)
Change "write" to "allow writing into" so reflects better what getChannelData allows.
Fix up the script so bikeshed doesn't mangle it. Add an onload event listener so that when the doc is loaded we can run ListAmendments to add a list of the related changes for the change log.
…fer-prim-next-buttons
Adjust so bikeshed doesn't mangle it. Move the listener code into the same script segment so it's easy to find.
See c2361-1 for an example.
Updates the numbering to match. There are now 9 related changes.
This has basically been merged to #2363. Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff