Skip to content

RangeError is thrown only for negative cancelTime #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 26, 2021
Merged

RangeError is thrown only for negative cancelTime #2352

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e0b84e7
RangeError is thrown only for negative cancelTime
Jun 4, 2021
a3a4f3d
Add fixup.js needed for the candidate correction
Jun 4, 2021
4083f03
Remove fixup.js, it's inserter automatically
padenot Aug 26, 2021
7e462d0
Fix markup
padenot Aug 26, 2021
572d35d
Merge branch 'main' into v2-127-cancel-time-error
hoch Aug 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ function InsertButtons(node) {
window.addEventListener('load', (event) => {
// Add entries here for each change
ListAmendments("c2361", "Proposed Correction", "change-list-2361");
ListAmendments("c127", "Proposed Correction", "change-list-127");
ListAmendments("c2359", "Proposed Correction", "change-list-2359");
ListAmendments("c2373", "Proposed Correction", "change-list-2373");
});
Expand Down Expand Up @@ -3806,8 +3807,17 @@ Methods</h4>
the original timeline would have had at time \(t_c\).
</div>

<div class="correction proposed" id="c127-1">
<span class="marker">Candidate Correction Issue 127:</span>
<div class="amendment-buttons">
Buttons here
</div>
A {{RangeError}} is only thrown for negative cancelTime values for
cancelAndHoldAtTime and cancelScheduledValues. See <a
href="https://github.com/WebAudio/web-audio-api-v2/issues/127">Issue 127</a>
</div>
<pre class=argumentdef for="AudioParam/cancelAndHoldAtTime()">
cancelTime: The time after which any previously scheduled parameter changes will be cancelled. It is a time in the same time coordinate system as the {{AudioContext}}'s {{BaseAudioContext/currentTime}} attribute. <span class="synchronous">A {{RangeError}} exception MUST be thrown if <code>cancelTime</code> is negative or is not a finite number.</span> If {{AudioParam/cancelAndHoldAtTime()/cancelTime}} is less than {{BaseAudioContext/currentTime}}, it is clamped to {{BaseAudioContext/currentTime}}.
cancelTime: The time after which any previously scheduled parameter changes will be cancelled. It is a time in the same time coordinate system as the {{AudioContext}}'s {{BaseAudioContext/currentTime}} attribute. <span class="synchronous">A {{RangeError}} exception MUST be thrown if <code>cancelTime</code> is negative<del cite=#c127-1> or is not a finite number</del>. If {{AudioParam/cancelAndHoldAtTime()/cancelTime}} is less than {{BaseAudioContext/currentTime}}, it is clamped to {{BaseAudioContext/currentTime}}.
</pre>

<div>
Expand All @@ -3834,7 +3844,7 @@ Methods</h4>
removed from the timeline.

<pre class=argumentdef for="AudioParam/cancelScheduledValues()">
cancelTime: The time after which any previously scheduled parameter changes will be cancelled. It is a time in the same time coordinate system as the {{AudioContext}}'s {{BaseAudioContext/currentTime}} attribute. <span class="synchronous">A {{RangeError}} exception MUST be thrown if <code>cancelTime</code> is negative or is not a finite number.</span> If <code>cancelTime</code> is less than {{BaseAudioContext/currentTime}}, it is clamped to {{BaseAudioContext/currentTime}}.
cancelTime: The time after which any previously scheduled parameter changes will be cancelled. It is a time in the same time coordinate system as the {{AudioContext}}'s {{BaseAudioContext/currentTime}} attribute. <span class="synchronous">A {{RangeError}} exception MUST be thrown if <code>cancelTime</code> is negative<del cite=#c127-1> or is not a finite number</del>.</span> If <code>cancelTime</code> is less than {{BaseAudioContext/currentTime}}, it is clamped to {{BaseAudioContext/currentTime}}.
</pre>

<div>
Expand Down Expand Up @@ -12875,6 +12885,9 @@ Change Log</h2>
* <a href="https://github.com/WebAudio/web-audio-api/issues/2361">Issue 2361</a>: Use new Web IDL buffer primitives
<div id="change-list-2361">
</div>
* <a href="https://github.com/WebAudio/web-audio-api-v2/issue/127">Issue 127</a>: RangeError is thrown only for negative cancelTime
<div id="change-list-127">
</div>
* <a href="https://github.com/WebAudio/web-audio-api/issue/2359">Issue 2359</a>: Fix a typo in the VUMeterNode example
<div id="change-list-2359">
</div>
Expand Down