Skip to content

Conversation

@pchickey
Copy link
Collaborator

Creates a Github Actions CI configuration, which should do the exact same thing as the Azure Pipelines CI did.

Deletes Azure Pipelines configuration.

Replaces #80

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! lgtm % it passing

@pchickey
Copy link
Collaborator Author

It appears to spin up 5 separate build jobs for each platform, when it should only do 2 - one for push, one for PR (which tests the merge commit iirc). I closed the last PR to see if some leftover state was causing that weirdness.

@sbc100
Copy link
Member

sbc100 commented Nov 25, 2019

Yeah, I thinks the expected behavior (its what travis does too I think). One is testing the actual thing you pushed, one is testing the PR (i.e. after integration with master). Shame its not smart enough to know that that is the same thing in almost all cases when you are working on top of master anyway.

@sbc100
Copy link
Member

sbc100 commented Nov 25, 2019

Can can probably make do with all pull_requests to be tested, and push only for master?

@pchickey
Copy link
Collaborator Author

right, i expect it to test those two, on mac os and on linux, so 4 jobs total. But on my screen there are 10 jobs total, and the other 6 are all dupes.

The good news is that #83, which has an identical workflow, seems to have the right number of jobs.

@sbc100
Copy link
Member

sbc100 commented Nov 25, 2019

Oh sorry, ignore me.. that doe s indeed look strange.

@pchickey pchickey merged commit ac571d0 into master Nov 26, 2019
@pchickey pchickey deleted the pch/gh_actions_ci branch November 26, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants