Skip to content

Conversation

@sbc100
Copy link
Member

@sbc100 sbc100 commented May 17, 2020

These were generated using latest wasmtime release (0.16.0) and the
wasi-sdk 10 release binaries.

These were generated using latest wasmtime release (0.16.0) and the
wasi-sdk 10 release binaries.
@sbc100 sbc100 requested a review from sunfishcode May 17, 2020 01:32
@sbc100
Copy link
Member Author

sbc100 commented May 17, 2020

Are these differences to be expected @sunfishcode ?

@sbc100
Copy link
Member Author

sbc100 commented May 17, 2020

I'm also seeing a failure in the stat.c tests (seems like lstat is failing):

--- /dev/null	2020-04-08 17:47:21.816001886 -0700
+++ stat.c.-O0.stderr.observed	2020-05-16 18:42:23.772233121 -0700
@@ -0,0 +1,15 @@
+Assertion failed: n == 0 (stat.c: main: 59)
+Error: failed to run main module `stat.c.-O0.wasm`
+
+Caused by:
+    0: failed to invoke `_start`
+    1: wasm trap: unreachable
+       wasm backtrace:
+         0: 0x3198 - <unknown>!abort
+         1: 0x3ae6 - <unknown>!__assert_fail
+         2:  0xba2 - <unknown>!main
+         3: 0x399a - <unknown>!__main_argc_argv
+         4: 0x3a16 - <unknown>!__main_void
+         5: 0x3a7e - <unknown>!__original_main
+         6:  0x2e6 - <unknown>!_start
+  

@sunfishcode
Copy link
Member

For the trap messages, Wasmtime recently changed its output to format the backtrace offsets differently. The change you have here is fine for now, though of course it'd be good to find a more general way of handling this too.

For the destructor changes, the change here is incorrect. The difference is due to a bug that this patch fixes, and that fix isn't in the 10.x release branch. We probably need to disable that test when running with clang <= 10.

The stat.c failure appears to be a recent regression in Wasmtime. We're investigating.

@pchickey pchickey mentioned this pull request Jun 1, 2020
Base automatically changed from master to main January 19, 2021 23:27
kildom pushed a commit to kildom/clang-wasi-port that referenced this pull request Jul 14, 2021
* Make __wasi_linkcount_t a uint64_t (WebAssembly#134)

Refs: WebAssembly/WASI#127

* Generate the WASI interface from witx.

This replaces the hand-maintained <wasi/core.h> header with a
<wasi/api.h> generated from witx.

Most of the churn here is caused by upstream WASI renamings; hopefully
in the future ABI updates will be less noisy.
@abrown
Copy link
Collaborator

abrown commented Jul 25, 2023

This is outdated.

@abrown abrown closed this Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants