chore: Updates wasi-logging to have a version #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricochet
reviewed
Oct 2, 2024
As I was starting to build and push all of these interfaces to work with wkg, I realized this didn't even have a version yet which means `wkg` won't even work with it. It also should just have a version. I am just making this a plain 0.1.0 because versions are free and they don't need to match the other p2 worlds. If we want to modify this, we just bump to a 0.2.0-beta or something similar Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
chore/add_version
branch
from
9f6dcca to
686a09b
Compare
ricochet
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was starting to build and push all of these interfaces to work with wkg, I realized this didn't even have a version yet which means
wkgwon't even work with it. It also should just have a version. I am just making this a plain 0.1.0 because versions are free and they don't need to match the other p2 worlds. If we want to modify this, we just bump to a 0.2.0-beta or something similar