Adjust Makefile for LLVM trunk (16) as of 2023-01-05 #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvm/llvm-project@d227c3b added __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.
sbc100
approved these changes
Jan 10, 2023
Member
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
We should probably go through and remove some of the older filters here (assuming we aren't trying to support very old versions of llvm).
lgtm to this though
Contributor
Author
|
I guess the main question would be: what would be the new baseline version? (CI tests LLVM 10, for instance, but the hacks go back to at least version 8). |
Member
|
We almost certainly don't support building wasi-libc with LLVM 8 or 9 anymore; if someone wanted to remove the hacks, that'd be great! |
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
llvm/llvm-project@d227c3b added __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.
bob-beck
pushed a commit
to openbsd/ports
that referenced
this pull request
Dec 7, 2023
switch to build with ports-clang 16, cf for llvm support: - WebAssembly/wasi-libc#379 - WebAssembly/wasi-libc#285 - WebAssembly/wasi-libc#344 adapt a regex to deal with our egrep syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llvm/llvm-project@d227c3b added __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros.