why no dedicated __wasi_snapshot_preview1_fd_openat syscall? #454

Activity

1. trcrsired commented on Dec 14, 2023

   

   trcrsired

   on Dec 14, 2023

   Author

   More actions

   wasi-libc/libc-bottom-half/sources/preopens.c

   Line 169 in a796d87

   int __wasilibc_find_relpath(const char *path,

   
   This is too complicated and not thread safe probably
2. sbc100 commented on Dec 14, 2023

   

   sbc100

   on Dec 14, 2023

   Member

   More actions

   I just realized the open(2) is too complicated on wasm and even this syscall is too complicated https://github.com/trcrsired/wasi-libc/blob/c8352f8c145fe1fc21db79893f45ed7aa4d9eef2/libc-bottom-half/sources/__wasilibc_real.c#L437

   There are no reasons to be so complicated tbh. Why no just a dedicated __wasi_snapshot_preview1_fd_openat syscall?

   IIUC correctly __wasi_snapshot_preview1_path_open is effectively syscall_openat. Its first argument is a file descriptor which is non-optional. What preview1 does not have (by design) is syscall_open (without the fd argument).