Skip to content

feat(p3): model body after stream<u8, trailers, error-code> #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 12 additions & 23 deletions wit-0.3.0-draft/types.wit
Original file line number Diff line number Diff line change
Expand Up @@ -240,27 +240,18 @@ interface types {
/// trailers at any given time.
resource body {

/// Construct a new `body` with the specified stream.
/// Construct a new `body` with the specified stream and `finish` future.
///
/// This function returns a future, which will resolve
/// to an error code if transmitting stream data fails.
/// The `finish` future must resolve to a result once `stream` has finished.
///
/// The returned future resolves to success once body stream
/// is fully transmitted.
new: static func(
%stream: stream<u8>,
) -> tuple<body, future<result<_, error-code>>>;

/// Construct a new `body` with the specified stream and trailers.
///
/// This function returns a future, which will resolve
/// to an error code if transmitting stream data or trailers fails.
/// This function returns a future, which will resolve to an error code if
/// transmitting of the request or response this body is a part of fails.
///
/// The returned future resolves to success once body stream and trailers
/// are fully transmitted.
new-with-trailers: static func(
/// The returned future resolves to success once request or response this
/// body is a part of is fully transmitted.
new: static func(
%stream: stream<u8>,
trailers: future<trailers>
finish: future<result<option<trailers>, error-code>>,
) -> tuple<body, future<result<_, error-code>>>;

/// Returns the contents of the body, as a stream of bytes.
Expand All @@ -286,8 +277,7 @@ interface types {
/// `none` values for `path-with-query`, `scheme`, and `authority`.
///
/// * `headers` is the HTTP Headers for the Response.
/// * `body` is the optional contents of the body, possibly including
/// trailers.
/// * `body` is the contents of the body, possibly including trailers.
/// * `options` is optional `request-options` to be used if the request is
/// sent over a network connection.
///
Expand All @@ -298,7 +288,7 @@ interface types {
/// to reject invalid constructions of `request`.
constructor(
headers: headers,
body: option<body>,
body: body,
options: option<request-options>
);

Expand Down Expand Up @@ -413,11 +403,10 @@ interface types {
/// `set-status-code` method.
///
/// * `headers` is the HTTP Headers for the Response.
/// * `body` is the optional contents of the body, possibly including
/// trailers.
/// * `body` is the contents of the body, possibly including trailers.
constructor(
headers: headers,
body: option<body>,
body: body,
);

/// Get the HTTP Status Code for the Response.
Expand Down