Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is-same-object, metadata-hash and metadata-hash-at: add missing this: descriptor argument #126

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

pchickey
Copy link
Contributor

These are methods on file/directory descriptors. Add those missing arguments.

@pchickey pchickey requested a review from sunfishcode July 31, 2023 23:55
@pchickey pchickey force-pushed the pch/metadata_hash_fixes branch from 63be06d to 7c967e5 Compare July 31, 2023 23:57
@pchickey pchickey changed the title metadata-hash and metadata-hash-at: add missing this: descriptor argument is-same-object, metadata-hash and metadata-hash-at: add missing this: descriptor argument Aug 1, 2023
@pchickey pchickey force-pushed the pch/metadata_hash_fixes branch from 1212685 to 19764b1 Compare August 1, 2023 16:40
@sunfishcode
Copy link
Member

Thanks! I'll merge this directly, as this is indeed the intention for these functions.

@sunfishcode sunfishcode merged commit e57c332 into main Aug 1, 2023
@sunfishcode sunfishcode deleted the pch/metadata_hash_fixes branch August 1, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants