Document that filesystem timestamps can be 0. #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A value of 0 in a timestamp indicates the time is unknown. This ports #531 from Preview 1 to Preview 2.
sunfishcode
force-pushed
the
sunfishcode/zero-timestamp
branch
from
49f6242 to
e2801cd
Compare
pchickey
approved these changes
Jul 21, 2023
|
Why did you choose a sentinel value over |
sunfishcode
force-pushed
the
sunfishcode/zero-timestamp
branch
from
621aff4 to
eda4f61
Compare
Ah, I guess I was just thinking in terms of preview1. But you're right, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A value of 0 in a timestamp indicates the time is unknown. This ports #531 from Preview 1 to Preview 2.