Remove timezone interface from the proposal for shipping Preview 2 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2023 10:22
We believe there is value in providing timezone support in this package, but for the sake of shipping Preview 2, we are out of time to implement these methods and test a a cross platform implementation of these in two separate engines. We intend for this interface to return to the wasi:clocks package and be made in a post-Preview 2 patch version 0.2.n. Re-introducing this interface may be done with a revert of this commit once we have shipped Preview 2 and figured out the process for shipping patch versions.
pchickey
changed the title
pchickey
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Nov 9, 2023
This was referenced Nov 9, 2023
github-merge-queue bot
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Nov 10, 2023
* delete wasi-clocks timezone interface: import wit changes from WebAssembly/wasi-clocks#55 * remove other references to wasi:clocks/timezone in wits * remove todo! implementation of clocks/timezone and add_to_linker funcs
elliottt
approved these changes
Nov 10, 2023
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 12, 2023
* delete wasi-clocks timezone interface: import wit changes from WebAssembly/wasi-clocks#55 * remove other references to wasi:clocks/timezone in wits * remove todo! implementation of clocks/timezone and add_to_linker funcs
alexcrichton
added a commit
to bytecodealliance/wasmtime
that referenced
this pull request
Nov 13, 2023
* Remove timezone interface from wasi-clocks (#7515) * delete wasi-clocks timezone interface: import wit changes from WebAssembly/wasi-clocks#55 * remove other references to wasi:clocks/timezone in wits * remove todo! implementation of clocks/timezone and add_to_linker funcs * Move the `wasi:io/stream/error` resource into `wasi:io/error` (#7521) * Move the `error` resource into `wasi:io/error` * error.wit: update doc comments * downstream fixes to streams.wit doc comments * fix package name in error.wit --------- Co-authored-by: Trevor Elliott <telliott@fastly.com> * wasi-http: Make child fields immutable (#7524) * Make child fields immutable * Add `get_fields` and remove `FieldMapMutability` Clean up the interface to immutable fields by adding a different accessor. * Clean up the diff * wasi-http: Migrate to more descriptive error variant (#7434) * Migrate to a more specific error-code variant in wasi-http Co-authored-by: Pat Hickey <phickey@fastly.com> * Optional fields, and align with upstream pr * Update for upstream changes to the error-code variant * Sync with the upstream implementation * Missed updating an error for riscv64 and s390x * More debuggable error prtest:full * Try to stabilize the test on windows --------- Co-authored-by: Pat Hickey <phickey@fastly.com> * Remove a debugging eprintln (#7528) * Remove no-longer-necessary reactor world (#7516) The `wasi:cli` WIT package now has a `reactor` world so the adapter can use that instead of defining its own. --------- Co-authored-by: Pat Hickey <phickey@fastly.com> Co-authored-by: Trevor Elliott <telliott@fastly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We believe there is value in providing timezone support in this package,
but for the sake of shipping Preview 2, we are out of time to implement
these methods and test a a cross platform implementation of these in two
separate engines.
We intend for this interface to return to the wasi:clocks package and
be made in a post-Preview 2 patch version 0.2.n. Re-introducing this
interface may be done with a revert of this commit once we have shipped
Preview 2 and figured out the process for shipping patch versions.