Add initial coredump document #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Dec 8, 2022
xtuc
force-pushed
the
sven/add-initial-coredump
branch
3 times, most recently
from
055fafc
to
976918d
Compare
dschuff
reviewed
Dec 9, 2022
6 tasks
dschuff
reviewed
Dec 16, 2022
xtuc
force-pushed
the
sven/add-initial-coredump
branch
from
6840fb6
to
e80c51d
Compare
dschuff
approved these changes
Dec 21, 2022
Co-authored-by: Derek Schuff <dschuff@chromium.org>
|
Please merge when you are happy to. As I said, I'm going to iterate on the format to address what we discussed at the CG meeting. |
|
Thanks! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #190.
Adapted from https://github.com/xtuc/wasm-coredump-format. I suggest we start with my initial idea and iterate on the design, does that make sense? I'm planning to send followup changes to address points we discussed during the CG.