Make non-natural alignment a validation error in spec interpreter / test #242
+435
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Jan 29, 2026
stevenfontanella
changed the title
tlively
approved these changes
Feb 3, 2026
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
LGTM. Let's see what @conrad-watt and @rossberg think.
rossberg
reviewed
Feb 3, 2026
Member
rossberg
left a comment
rossberg
left a comment
There was a problem hiding this comment.
Looks good, I only have stylistic nits regarding the validator change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #243. Prior to #243, a non-natural alignment for an atomic instruction was not a parse, validation or runtime failure in the spec interpreter / tests, although the spec specified that it would be a parse error (and would be a validation error after #243). Change the reference interpreter and spec test to make a non-natural alignment into a validation error. 8-bit instructions aren't tested for the validation failure since there's no way to have a non-natural alignment for those cases (only a greater one which results in a different validation failure).
Also removed some extra spaces in cmpxchg tests.
Tested with
make testlocally.