Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use official WebAssembly logo #513

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Conversation

chicoxyzzy
Copy link
Member

Attention: PDF build failed on my laptop so I'm not sure it works as expected (I use SVG logo here).
Part of log:

latexmk -pdf -dvi- -ps-  'WebAssembly.tex'
make[1]: latexmk: No such file or directory
make[1]: *** [WebAssembly.pdf] Error 1
make: *** [latexpdf] Error 2

Screenshot of HTML page:
screen shot 2017-06-28 at 13 08 40

fixes #477

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Jun 28, 2017

Can I check built PDF file on Travis somehow?

@rossberg
Copy link
Member

No, the spec build hasn't been set up for Travis, though that might be worth looking into.

I tried it on my machine, and unfortunately I get "! LaTeX Error: Unknown graphics extension: .svg.". But I suppose a JPG or PNG should be good enough for this purpose.

One question: would it be possible to make the logo appear somewhat smaller, with more space around it? As is it looks rather overblown and cramped on the page.

@chicoxyzzy
Copy link
Member Author

chicoxyzzy commented Jun 29, 2017

Updated to use PNG instead of SVG. Also I installed MacTex instead of BasicTex and was able to sure PDF was built without any issues.

@rossberg-chromium AFAIK Sphinx theme used here doesn't support such option and logo size is aligned to navigation bar width. I think it's possible to use css rules but I'm not good at CSS.

@rossberg
Copy link
Member

Thanks! I will look into tweaking the CSS (though I'm not at all good at that either).

@rossberg rossberg merged commit 1c4910d into WebAssembly:master Jun 29, 2017
ngzhian pushed a commit to ngzhian/spec that referenced this pull request Nov 4, 2021
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Feb 12, 2024
[spec] Add note and algorithmic rules about typing with top type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[spec] Use official WebAssembly logo
2 participants