-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to gh-pages #449
Add link to gh-pages #449
Conversation
README.md
Outdated
@@ -10,6 +10,8 @@ specification language. | |||
It also holds the WebAssembly testsuite, which tests numerous aspects of | |||
conformance to the spec. | |||
|
|||
View the spec at [webassembly.github.io/spec](webassembly.github.io/spec/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a broken link. Without a scheme, it gets treated as a relative link to:
https://github.com/WebAssembly/spec/blob/master/webassembly.github.io/spec
Which is 404.
To fix that, you should add a scheme, preferably https://.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks my bad
Thanks! How about changing that to "work-in-progress spec", for extra clarity? Can you be a bit more specific about what "URL on the repository" you are referring to in your PS? |
Alright I updated the text, and @shurcooL is correct |
Thanks @jamen. @shurcooL, I see. Seems like I don't have the necessary admin rights to change this. @lukewagner, do you have access? |
…#449) * Skip _output directory when listing wast files for test. Follow-up to WebAssembly#434. Now `make partest && make partest` shouldn't fail. * Use a simpler glob Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Add missing init expression to table text format
I built the html locally before I knew the gh-pages existed. Would good to link it somewhere?
P.S. The URL on the repository just points to
webassembly.github.io
, instead of with/spec
. Might be a typo.