Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to gh-pages #449

Merged
merged 4 commits into from
Apr 4, 2017
Merged

Add link to gh-pages #449

merged 4 commits into from
Apr 4, 2017

Conversation

jamen
Copy link

@jamen jamen commented Mar 30, 2017

I built the html locally before I knew the gh-pages existed. Would good to link it somewhere?

P.S. The URL on the repository just points to webassembly.github.io, instead of with /spec. Might be a typo.

README.md Outdated
@@ -10,6 +10,8 @@ specification language.
It also holds the WebAssembly testsuite, which tests numerous aspects of
conformance to the spec.

View the spec at [webassembly.github.io/spec](webassembly.github.io/spec/).
Copy link
Contributor

@dmitshur dmitshur Mar 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a broken link. Without a scheme, it gets treated as a relative link to:

https://github.com/WebAssembly/spec/blob/master/webassembly.github.io/spec

Which is 404.

To fix that, you should add a scheme, preferably https://.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks my bad

@rossberg
Copy link
Member

rossberg commented Apr 3, 2017

Thanks! How about changing that to "work-in-progress spec", for extra clarity?

Can you be a bit more specific about what "URL on the repository" you are referring to in your PS?

@dmitshur
Copy link
Contributor

dmitshur commented Apr 3, 2017

Can you be a bit more specific about what "URL on the repository" you are referring to in your PS?

I think he's referring to the URL that's next to the repository description. See the bottom right corner of this screenshot:

image

@jamen
Copy link
Author

jamen commented Apr 3, 2017

Alright I updated the text, and @shurcooL is correct

@rossberg rossberg merged commit 236280c into WebAssembly:master Apr 4, 2017
@rossberg
Copy link
Member

rossberg commented Apr 4, 2017

Thanks @jamen.

@shurcooL, I see. Seems like I don't have the necessary admin rights to change this. @lukewagner, do you have access?

ngzhian added a commit to ngzhian/spec that referenced this pull request Nov 4, 2021
…#449)

* Skip _output directory when listing wast files for test.

Follow-up to WebAssembly#434.
Now `make partest && make partest` shouldn't fail.

* Use a simpler glob

Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
dhil pushed a commit to dhil/webassembly-spec that referenced this pull request Oct 20, 2023
Add missing init expression to table text format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants