Fix a few binary version tests #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I missed updating a few cases to version 1 in binary.wast that are meant to test endianness.
dschuff
approved these changes
Feb 24, 2017
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
v128.store8_lane v128.store16_lane v128.store32_lane v128.store64_lane Introduce a new ast type, SimdStoreLane. The exact binary opcodes for these instructions are not yet fixed, I've used the ones currently implement in V8 and LLVM/Binaryen, we can change those later. Also added a new test generation script, and the generated test files. * Fix indent in lexer * Simplify simd load/store lane validation * Inline store_simd_lane into eval.ml * Inline load_simd_lane into eval.ml
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
Fix rectype opcodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed updating a few cases to version 1 in binary.wast that are meant
to test endianness.