Yet another batch of tests #295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let num = digit+ | ||
| let hexnum = "0x" hexdigit+ | ||
| let nat = num | hexnum | ||
| let int = sign nat |
There was a problem hiding this comment.
Would it make sense to make int be sign? nat, so that productions like literal don't have to match both int and nat?
Also, what is nat short for?
There was a problem hiding this comment.
@sunfishcode, tokens necessarily define disjoint lexical classes, so to carve out a subclass you need to union in the parser.
Yes, nat is "natural".
|
Any opposition to landing these tests as well? |
|
Nope |
|
Merged into master manually, because Github. |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
It was incorrectly using the non-saturing versions, leading to runtime traps.
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Oct 3, 2023
rossberg
pushed a commit
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time:
Also, syntax now disallows signs for any numbers that are uints in the binary encoding.