[spec/test] Relax relaxed_trunc semantics #1906
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dtig, this implements the relaxation for relaxed_trunk we have converged on, PTAL.
I also removed all core tests that became obsolete/incorrect with this change. Unfortunately, it turns out that there are none left for relaxed_trunc, which is a bit concerning.
In fact, I then had a look at the tests for the other Relaxed SIMD instructions, and almost all of them only test a few edge cases. That is, with the exception of 5 assertions about
relaxed_dot
, we seem to have no tests for the “regular” behaviour of these instructions at all! That’s not good. Could somebody work on creating a suitable suite of basic tests? ;)