Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the definition of tagtype from functype into deftype #1862

Merged
merged 3 commits into from
Jan 13, 2025

Conversation

f52985
Copy link
Contributor

@f52985 f52985 commented Jan 10, 2025

This PR changes the definition of tagtype, which was previously functype, into deftype,
and also modifies (hopefully) every use site of it, accordingly.

The issue arised from the fact that the exn proposal and the gc proposal were being developed independently,
and they were not merged properly.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks a lot!

f52985 and others added 2 commits January 10, 2025 21:17
Match heading length

Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Add note for seemingly identical premise and conclusion

Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
@f52985
Copy link
Contributor Author

f52985 commented Jan 13, 2025

Oh, it seems that I don't have the write access for this repository. @rossberg, could you merge this pull request?

@rossberg rossberg merged commit 62893c2 into WebAssembly:wasm-3.0 Jan 13, 2025
11 checks passed
@f52985 f52985 deleted the tagtype branch February 10, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants