Skip to content

[js-api][web-api] Use the 'react' algorithm from WebIDL #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[js-api][web-api] Use the 'react' algorithm from WebIDL #1835

wants to merge 2 commits into from
+35 −31

Conversation

Ms2ger
Copy link
Collaborator

@Ms2ger Ms2ger commented Oct 24, 2024

Fixes #1834.

@ADKaster
Copy link

Thanks for drafting this so quickly! I think the comment from 1834 also applies to https://webassembly.github.io/spec/js-api/#instantiate-a-promise-of-a-module

@Ms2ger Ms2ger changed the title [web-api] Use the 'react' algorithm from WebIDL [js-api][web-api] Use the 'react' algorithm from WebIDL Oct 28, 2024
@rossberg
Copy link
Member

@Ms2ger, is this old PR still relevant? If so, who could review it?

@Ms2ger Ms2ger requested a review from eqrion September 11, 2025 09:32
eqrion
eqrion approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@eqrion eqrion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Promises are 'fun'. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@eqrion eqrion eqrion approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebAssembly Web API specification should use WebIDL react to promise
4 participants
@Ms2ger @ADKaster @rossberg @eqrion