-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[build] Update katex submodule #1726
Conversation
33db90f
to
384499c
Compare
Isn't that a submodule? Looking at .gitmodules, was that even versioned? I'm confused about the diff GH shows for this PR, which only contains the submodule directory. What actual repository file does the commit change? |
This is just changing the hash that git and GitHub store for the revision of the repo for the submodule. That hash isn’t persistently stored in any files checked into the repo, but is instead just internal metadata that’s stored locally in the
It is, yeah
I think
…and running it in environment with the change from this PR branch shows this:
git stores that hash/version info locally in the
It just changes the hash that git and GitHub store for the revision of the repo for the submodule. I don’t know where GitHub stores it. As far as I know, https://github.com/WebAssembly/spec/tree/main/document/core/util is the place in the GitHub UI where that hash is exposed/observable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation. Obviously, I don't understand how git submodules work. :)
I can’t actually claim to understand how git submodules work either :D What I outlined in my comment above is pretty much the full extent of my knowledge on the subject… |
Without this update, running the build locally in my macOS environment fails with a bunch of errors containing the message “➤ YN0001: │ Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close”.