This repository has been archived by the owner on Dec 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Rename integer-to-integer widening instructions to "extend"? #467
Comments
SGTM |
If we switch from |
The scalar spec has |
We can keep narrow since there is no equivalent instruction in scalar spec. |
There were no strong objections to this renaming at today's meeting. @ngzhian, do you want to put a PR together? |
ngzhian
added a commit
to ngzhian/simd
that referenced
this issue
Feb 19, 2021
Changes to interpreter will come in a follow-up patch. Fixed WebAssembly#467.
ngzhian
added a commit
that referenced
this issue
Feb 23, 2021
Changes to interpreter will come in a follow-up patch. Fixed #467.
ngzhian
added a commit
to ngzhian/simd
that referenced
this issue
Feb 23, 2021
ngzhian
added a commit
that referenced
this issue
Feb 24, 2021
ngzhian
added a commit
to ngzhian/wasmparser
that referenced
this issue
Mar 2, 2021
See WebAssembly/simd#452 for finalized opcodes and WebAssembly/simd#467 for some renamings.
ngzhian
added a commit
to ngzhian/wasmparser
that referenced
this issue
Mar 2, 2021
See WebAssembly/simd#452 for finalized opcodes and WebAssembly/simd#467 for some renamings.
ngzhian
added a commit
to ngzhian/wasmparser
that referenced
this issue
Mar 3, 2021
See WebAssembly/simd#452 for finalized opcodes and WebAssembly/simd#467 for some renamings.
bmeurer
pushed a commit
to wasdk/wasmparser
that referenced
this issue
Mar 4, 2021
See WebAssembly/simd#452 for finalized opcodes and WebAssembly/simd#467 for some renamings.
24 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Referring to this section https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#integer-to-integer-widening, was there a reason why we chose "widen"? That isn't a terminology used in the current Wasm spec, it uses "extend" (e.g. see https://webassembly.github.io/spec/core/appendix/index-instructions.html).
Can we change the names to extend? (Everything else stays the same, only
s/widen/extend/
.The text was updated successfully, but these errors were encountered: