This repository was archived by the owner on Jan 15, 2025. It is now read-only.
Add index constructor argument for WebAssembly.Table #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to WebAssembly.Memory (WebAssembly#39), the WebAssembly.Table constructor also needs an `index` argument.
rossberg
reviewed
Jun 5, 2024
document/js-api/index.bs
Outdated
| @@ -779,10 +779,16 @@ enum TableKind { | |||
| // e.g., typed function references, typed GC references | |||
| }; | |||
|
|
|||
| enum TableIndexType { | |||
There was a problem hiding this comment.
Can we not merge these into a single IndexType?
sbc100
approved these changes
Jun 5, 2024
|
Index types merged. |
bvisness
pushed a commit
to bvisness/memory64
that referenced
this pull request
Aug 1, 2024
Similar to WebAssembly.Memory (WebAssembly#39), the WebAssembly.Table constructor also needs an `index` argument.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to WebAssembly.Memory (#39), the WebAssembly.Table constructor also needs an
indexargument.This fixes #63.