Skip to content

[GC] Properly mark Unsubtyping as closed-world #8029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2025
Merged

[GC] Properly mark Unsubtyping as closed-world #8029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d542a41
Properly mark Unsubtyping as closed-world
kripken Nov 7, 2025
60fd544
fix random test
kripken Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion scripts/fuzz_opt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2486,7 +2486,8 @@ def write_commands(commands, filename):
("--cfp-reftest",),
("--gsi",),
("--type-ssa",),
("--type-merging",)}
("--type-merging",),
("--unsubtyping",)}


def get_random_opts():
Expand Down
4 changes: 4 additions & 0 deletions src/passes/Unsubtyping.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,10 @@ struct Unsubtyping : Pass {
return;
}

if (!getPassOptions().closedWorld) {
Fatal() << "Unsubtyping requires --closed-world";
}

// Initialize the subtype relation based on what is immediately required to
// keep the code and public types valid.
analyzePublicTypes(*wasm);
Expand Down
2 changes: 1 addition & 1 deletion test/lit/passes/issue-7087.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
;; module-level code in TypeSSA and fix the validator so it would have caught
;; the stale type.

;; RUN: wasm-opt %s -all --type-ssa --unsubtyping -S -o - | filecheck %s
;; RUN: wasm-opt %s -all --type-ssa --unsubtyping --closed-world -S -o - | filecheck %s

(module
;; CHECK: (rec
Expand Down
Loading