Use GLB in PossibleContents::intersect #7550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the standard utility rather than reimplementing type intersection. The new code is simpler, shorter, and properly supports exactness, avoiding an assertion failure in the added test case. The other functional change is that when one of the intersected heap types is bottom and the type GLB is a non-nullable reference to bottom, the result of the intersection is `None` where it was previously a `Cone`.
kripken
reviewed
Apr 28, 2025
| ;; CHECK-NEXT: (global.get $global) | ||
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: (ref.null none) |
There was a problem hiding this comment.
Why did this change? Previously the ref.cast emitted a nullable bottom type, and it should still keep doing so IIUC... the description mentions a change to non-nullable ones, but that's not the case here, so it must be something else?
There was a problem hiding this comment.
This is what I was referring to with non-nullable references because the possible contents in $global is a non-null value, even though its static type is nullable.
There was a problem hiding this comment.
Oh right, the actual value is non-nullable, thanks!
kripken
approved these changes
Apr 28, 2025
| ;; CHECK-NEXT: (global.get $global) | ||
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: ) | ||
| ;; CHECK-NEXT: (ref.null none) |
There was a problem hiding this comment.
Oh right, the actual value is non-nullable, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the standard utility rather than reimplementing type intersection.
The new code is simpler, shorter, and properly supports exactness,
avoiding an assertion failure in the added test case. The other
functional change is that when one of the intersected heap types is
bottom and the type GLB is a non-nullable reference to bottom, the
result of the intersection is
Nonewhere it was previously aCone.