Add a Tarjan's Strongly Connected Component utilty #6790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a non-recursive version of Tarjan's Strongly Connected Component algorithm that consumes and produces iterators for maximum flexibility. This will be used in an optimization that transforms the heap type graph to use minimal recursion groups, which correspond to the strongly connected components of the type graph.
kripken
reviewed
Jul 29, 2024
| std::unordered_map<T, size_t> indices; | ||
| // The smallest index of the elements reachable from each element through | ||
| // its subtree. | ||
| std::unordered_map<T, size_t> minReachable; |
Member
There was a problem hiding this comment.
Would these three perhaps be more efficient as a single map of a struct like this?
struct Info {
size_t index;
size_t lowlink;
bool onStack;
};
std::unordered_map<T, Info> infoMap; (Also those names match the names in the paper.)
kripken
approved these changes
Jul 30, 2024
test/gtest/scc.cpp
Outdated
| } | ||
|
|
||
| TEST(SCCTest, TwoAndOneRedundant) { | ||
| // 0 <-> 1 => 2 |
Member
There was a problem hiding this comment.
maybe
Suggested change
| // 0 <-> 1 => 2 | |
| // 2 <- 0 <-> 1 -> 2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a non-recursive version of Tarjan's Strongly Connected
Component algorithm that consumes and produces iterators for maximum
flexibility.
This will be used in an optimization that transforms the heap type graph
to use minimal recursion groups, which correspond to the strongly
connected components of the type graph.