[threads] Fix shared ref.eq and disallow mixed-shareability #6763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Jul 17, 2024
Update the validator to reject mixed-shareability ref.eq, although this is still under discussion in WebAssembly/shared-everything-threads#76. Fix the implementation of `Literal::operator==` to work properly with shared i31ref.
tlively
force-pushed
the
threads-fix-shared-i31-eq
branch
from
c10b9a6 to
a00f440
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the validator to reject mixed-shareability ref.eq, although this
is still under discussion in
WebAssembly/shared-everything-threads#76. Fix
the implementation of
Literal::operator==to work properly with sharedi31ref.