[StackIR] Allow StackIR to be disabled from the commandline #6725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlively
reviewed
Jul 10, 2024
Comment on lines
+6
to
+10
| ;; As above, but disallow it later. This does not optimize. | ||
| ;; RUN: wasm-opt %s --generate-stack-ir --optimize-stack-ir -all --no-stack-ir --print-stack-ir | filecheck %s --check-prefix=DISALLOWD | ||
|
|
||
| ;; As above, but flip it, so we allow it after disallowing. This optimizes. | ||
| ;; RUN: wasm-opt %s --no-stack-ir --generate-stack-ir --optimize-stack-ir -all --print-stack-ir | filecheck %s --check-prefix=REALLOWED |
Member
There was a problem hiding this comment.
Can you explain how these commands end up with different results? I am baffled.
Member
Author
There was a problem hiding this comment.
--no-stack-irsays "disable it"--optimize-stack-irsays "enable it"
And the last one on the commandline wins, just like -fno-exceptions -fexceptions etc.
Member
There was a problem hiding this comment.
Oh, I see, --optimize-stack-ir is handled in ToolOptions 👍
tlively
approved these changes
Jul 10, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally we use it when optimizing (above a certain level). This lets the user
prevent it from being used even then.
Also add optimization options to
wasm-metadceso that this is possiblethere as well and not just in
wasm-opt(this also opens the door to runningmore passes in metadce, which may be useful later).
A use case for this is Emscripten, which runs wasm-opt more than once.
We do not want to use StackIR in the earlier invocations, but only in the
last, for efficiency and also to avoid corner cases with the fixups for stacky
code ending up requiring more optimization work (see
emscripten-core/emscripten#22196, which will be fixed by this + another PR in
emscripten to use this).