[C API] Add APIs for getting/setting function types, and a CallRef example #6721
Conversation
There was a problem hiding this comment.
What would you think about putting this test in a gtest file? Compilation errors in the gtests are caught during the normal build and the tests run much faster, so they seem strictly better than the example tests.
There was a problem hiding this comment.
I agree this file might make sense as a gtest, yeah. There was the idea of having special "example" tests that are helpful for people to see code samples of the public API (as opposed to testing of internals, or corner cases of the public API), which is what "example" was meant to invoke, but I suppose we could make gtest/example and document that?
There was a problem hiding this comment.
Yeah, gtest/example would be great.
There was a problem hiding this comment.
I started to do this but then realized a big missing feature of our gtests atm, which is that they don't work with the auto updater script. So tests like this that match the text format output would need to be manually updated if we ever change the text format. Before we move any significant amount of such tests to gtest we should probably add auto-updating.
There was a problem hiding this comment.
(Which I agree is worth doing, but not trivial.)
2 participants
Fixes #6718