[WasmGC] Heap2Local: Optimize RefIs and RefTest #6705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d36281b.
Member
Author
|
friendly ping @tlively |
tlively
reviewed
Jul 9, 2024
Comment on lines
+774
to
+776
| // Remove the RefTest and leave only its reference child. If we kept it, | ||
| // we'd need to refinalize (as the input to the test changes, since the | ||
| // reference becomes a null, which has a different type). |
Member
There was a problem hiding this comment.
We could also keep only the operands of other operations we currently drop, which would add the very least make the code more consistent and reduce the number of IR nodes in the output.
Member
Author
There was a problem hiding this comment.
Fair enough, looks like that would affect just RefEq. I can do that separately from this PR.
tlively
approved these changes
Jul 11, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.