Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ Current Trunk
the PassOptions. As a result `BinaryenModulePrintStackIR` and similar APIs
do not receive an `optimize` flag, as they read the PassOption
`optimizeStackIR` instead.
- The new, standards-compliant text parser is now the default. `wasm-opt` has a
`--deprecated-wat-parser` flag that will switch back to using the old text
parser, but that option will go away soon.
- The new, standards-compliant text parser is now the default.
- Source map comments on `else` branches must now be placed above the
instruction inside the `else` branch rather than on the `else` branch itself.
- Source map locations from instructions are no longer automatically propagated
Expand Down
5 changes: 2 additions & 3 deletions Contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ Use this handy checklist to make sure your new instructions are fully supported:
- [ ] Interpretation added to src/wasm-interpreter.h
- [ ] Effects handled in src/ir/effects.h
- [ ] Precomputing handled in src/passes/Precompute.cpp
- [ ] Hashing and comparing in src/ir/ExpressionAnalyzer.cpp
- [ ] Parsing added in scripts/gen-s-parser.py, src/wasm-s-parser.h and src/wasm/wasm-s-parser.cpp
- [ ] Parsing added in scripts/gen-s-parser.py, src/parser/parsers.h, src/parser/contexts.h, src/wasm-ir-builder.h, and src/wasm/wasm-ir-builder.cpp
- [ ] Printing added in src/passes/Print.cpp
- [ ] Decoding added in src/wasm-binary.h and src/wasm/wasm-binary.cpp
- [ ] Binary writing added in src/wasm-stack.h and src/wasm/wasm-stack.cpp
Expand All @@ -30,4 +29,4 @@ Use this handy checklist to make sure your new instructions are fully supported:
- [ ] C API tested in test/example/c-api-kitchen-sink.c
- [ ] JS API tested in test/binaryen.js/kitchen-sink.js
- [ ] Tests added in test/spec
- [ ] Tests added in top-level test/
- [ ] Tests added in test/lit
2 changes: 1 addition & 1 deletion check.py
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ def run_spec_test(wast):

def run_opt_test(wast):
# check optimization validation
cmd = shared.WASM_OPT + [wast, '-O', '-all', '-q', '--new-wat-parser']
cmd = shared.WASM_OPT + [wast, '-O', '-all', '-q']
support.run_command(cmd)

def check_expected(actual, expected):
Expand Down
1,215 changes: 598 additions & 617 deletions scripts/gen-s-parser.py

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion src/binaryen-c.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include "wasm-binary.h"
#include "wasm-builder.h"
#include "wasm-interpreter.h"
#include "wasm-s-parser.h"
#include "wasm-stack.h"
#include "wasm-validator.h"
#include "wasm.h"
Expand Down
4 changes: 0 additions & 4 deletions src/emscripten-optimizer/parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,6 @@ IString STORE("store");
IString GETTER("get");
IString SETTER("set");

IStringSet
keywords("var const function if else do while for break continue return "
"switch case default throw try catch finally true false null new");

const char *OPERATOR_INITS = "+-*/%<>&^|~=!,?:.", *SEPARATORS = "([;{}";

int MAX_OPERATOR_SIZE = 3;
Expand Down
Loading