Skip to content

LocalCSE: Ignore traps of code in between #6588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2024
Merged

LocalCSE: Ignore traps of code in between #6588

merged 2 commits into from
May 14, 2024

Conversation

@kripken
Copy link
Member

@kripken kripken commented May 13, 2024 •
edited
Loading 

(ORIGINAL)
(in between)
(COPY)

We want to change that to

(local.tee $temp (ORIGINAL))
(in between)
(local.get $temp)

It is fine if "in between" traps: then we never reach the new local.get. This is a safer
situation than most optimizations because we are not reordering anything, only
replacing known-equivalent code.

@kripken kripken requested review from aheejin and tlively May 13, 2024 23:25
@kripken kripken merged commit 76a2c64 into WebAssembly:main May 14, 2024
@kripken kripken deleted the wy.cse.4 branch May 14, 2024 17:11
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tlively tlively tlively approved these changes

@aheejin aheejin aheejin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kripken @tlively @aheejin