Skip to content

Conversation

@tlively
Copy link
Member

@tlively tlively commented Apr 19, 2024

After the initial parsing pass to find the locations of all the module elements
and after the type definitions have been parsed, the next phase of parsing is to
visit all of the module elements and parse their types. This phase does not
require parsing function bodies, but it previously parsed entire functions
anyway for simplicity. To improve performance, skip that useless work.

Copy link
Member Author

tlively commented Apr 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlively and the rest of your teammates on Graphite Graphite

Copy link
Member Author

tlively commented Apr 19, 2024

Merge activity

  • Apr 19, 7:36 PM EDT: @tlively started a stack merge that includes this pull request via Graphite.
  • Apr 19, 7:38 PM EDT: Graphite rebased this pull request as part of a merge.
  • Apr 19, 8:07 PM EDT: @tlively merged this pull request with Graphite.

Base automatically changed from parser-idchar-perf to main April 19, 2024 23:37
After the initial parsing pass to find the locations of all the module elements
and after the type definitions have been parsed, the next phase of parsing is to
visit all of the module elements and parse their types. This phase does not
require parsing function bodies, but it previously parsed entire functions
anyway for simplicity. To improve performance, skip that useless work.
@tlively tlively force-pushed the parser-module-types-perf branch from 917e279 to b90b104 Compare April 19, 2024 23:37
@tlively tlively merged commit 219e668 into main Apr 20, 2024
@tlively tlively deleted the parser-module-types-perf branch April 20, 2024 00:07
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants