Skip to content

Fix writing of data segment names in name section #6462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix writing of data segment names in name section #6462

merged 1 commit into from
Apr 2, 2024

Conversation

@vouillon
Copy link
Contributor

@vouillon vouillon commented Apr 2, 2024

  • Output segment names even when no memory is declared
  • Only write explicit names

@vouillon
Fix writing of data segment names in name section
0bc345f 
- Output segment names even when no memory is declared
- Only write explicit names
kripken
kripken approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kripken kripken merged commit 35df504 into WebAssembly:main Apr 2, 2024
@vouillon vouillon deleted the data-segment-names branch April 2, 2024 17:12
@gkdn gkdn mentioned this pull request Aug 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kripken kripken kripken approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vouillon @kripken