Report timeout in interpretation of AtomicWait #6452
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid slow-running fuzz cases, we report a host limit when interpreting atomic.wait with any non-zero timeout. However, in the allowed case where the timeout is zero, we were incorrectly interpreting the wait as returning 0, meaning that it was woken up, instead of 2, meaning that the timeout expired. Fix it to return 2.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kripken
reviewed
Mar 29, 2024
| hostLimit("threads support"); | ||
| } | ||
| return Literal(int32_t(0)); // equal | ||
| return Literal(int32_t(2)); // Timed out |
Member
There was a problem hiding this comment.
I don't follow - if there is no timeout, how can we timeout?
Member
Author
There was a problem hiding this comment.
The timeout is zero nanoseconds.
Member
There was a problem hiding this comment.
Oh, I see, reading the spec more carefully indeed 0 is just a brief timeout in effect...
kripken
approved these changes
Mar 29, 2024
| hostLimit("threads support"); | ||
| } | ||
| return Literal(int32_t(0)); // equal | ||
| return Literal(int32_t(2)); // Timed out |
Member
There was a problem hiding this comment.
Oh, I see, reading the spec more carefully indeed 0 is just a brief timeout in effect...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid slow-running fuzz cases, we report a host limit when interpreting
atomic.wait with any non-zero timeout. However, in the allowed case where the
timeout is zero, we were incorrectly interpreting the wait as returning 0,
meaning that it was woken up, instead of 2, meaning that the timeout expired.
Fix it to return 2.