Remove extra conversion in string test #6426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`string.encode_wtf16_array` operates on stringref, not on wtf16 string views, so this conversion was causing validation errors when passed to V8 by the fuzzer.
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kripken
approved these changes
Mar 22, 2024
Member
|
It would be good to add validation as we find things like this, to prevent us adding more incorrect tests, though it's not urgent. |
Member
Author
|
Fortunately my work on ChildTyper will ensure that we have no missing validation of child types in any expression, and unfortunately that means that any new code checking child types is going to be very short lived. |
Member
|
Ah, great! Even better 😄 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
string.encode_wtf16_arrayoperates on stringref, not on wtf16 string views, sothis conversion was causing validation errors when passed to V8 by the fuzzer.