Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Mar 21, 2024

Context: The pass does (among other things) this:

(if
  condition
  X
  X
)

=>

(block
  (drop
    condition
  )
  X ;; deduplicated
)

After that the condition is now nested in a block, so we may need EH fixups
if it contains a pop.

@kripken kripken requested a review from aheejin March 21, 2024 19:27
Copy link
Member

@aheejin aheejin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kripken kripken merged commit 57dc0c9 into WebAssembly:main Mar 22, 2024
@kripken kripken deleted the eh.old.code-folding branch March 22, 2024 18:12
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants