Skip to content

Conversation

@tlively
Copy link
Member

@tlively tlively commented Mar 7, 2024

The checked in test outputs were out of sync with what the auto update script
produces.

The checked in test outputs were out of sync with what the auto update script
produces.
@tlively tlively requested a review from kripken March 7, 2024 19:58
@tlively
Copy link
Member Author

tlively commented Mar 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tlively and the rest of your teammates on Graphite Graphite

;; CHECK-NEXT: ;;@ a:2:1
;; CHECK-NEXT: (nop)
;; CHECK-NEXT: ;;@ a:3:1
;; CHECK-NEXT: )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this test lost all its testing - should it be a manual test perhaps? But why is this CHECK output vanishing - is it hitting an auto updater bug perhaps?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the function just needs to be named so that the update script can recognize it and match it up with the output. That's enough to test everything except the prologue source comment, which the update script does not know to emit.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Perhaps we should run the auto-updater script in CI... we've considered it in the past but it would make CI slower for little benefit aside from the rare case like this.

@tlively tlively merged commit d6c5e4a into main Mar 7, 2024
@tlively tlively deleted the regenerate-test-output branch March 7, 2024 23:04
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants