Expose features option in C API #6380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
reviewed
Mar 6, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Hi @surma , thanks, this looks like the right C API change here!
Code lgtm. Please just add a note to CHANGELOG.md and a small test to test/example/c-api-kitchen-sink.c (after adding it, running ./scripts/auto_update_tests.py example will update the output for that file).
Contributor
Author
|
@kripken I hope I did this right :) |
kripken
reviewed
Mar 6, 2024
kripken
reviewed
Mar 6, 2024
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Looks good aside from one comment!
Member
|
Looks like there is a CI error too, on lint: https://github.com/WebAssembly/binaryen/actions/runs/8177938588/job/22362367130?pr=6380 |
Co-authored-by: Alon Zakai <alonzakai@gmail.com>
Contributor
Author
|
Fixed! |
kripken
reviewed
Mar 6, 2024
surma
force-pushed
the
surma/c-api-features
branch
from
3e1af54 to
43487fa
Compare
kripken
approved these changes
Mar 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am currently in need of setting features from the C API, so I figured I’d take a stab at fixing the TODO.
Not sure if this is the way you’d wanna go about it, though. Happy to adjust!