Update the text syntax for tuple types #6246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
kripken
reviewed
Jan 25, 2024
|
|
||
| ;; CHECK: (global $referredField@Foo i32 (i32.const 42)) | ||
| (global $referredField@Foo (i32) (i32.const 42)) | ||
| (global $referredField@Foo i32 (i32.const 42)) |
Member
There was a problem hiding this comment.
Was this needed because before it was a tuple of size 1? But I thought we errored on that...
Member
Author
There was a problem hiding this comment.
Syntactically it was a tuple of size one, which should not have been valid, but when we actually try to construct a tuple of size one the type we get back is just the element type, so this ended up Just Working before.
18 tasks
kripken
approved these changes
Jan 25, 2024
Instead of e.g. `(i32 i32)`, use `(tuple i32 i32)`. Having a keyword to introduce the s-expression is more consistent with the rest of the language.
radekdoulik
pushed a commit
to dotnet/binaryen
that referenced
this pull request
Jul 12, 2024
Instead of e.g. `(i32 i32)`, use `(tuple i32 i32)`. Having a keyword to introduce the s-expression is more consistent with the rest of the language.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of e.g.
(i32 i32), use(tuple i32 i32). Having a keyword tointroduce the s-expression is more consistent with the rest of the language.