Skip to content

Conversation

@kripken
Copy link
Member

@kripken kripken commented Jan 25, 2024

The JS there is not an ES6 module, so declare it so (otherwise a package.json in a
parent, perhaps in folders outside of our own project that we are pasted in, can
cause an error, as require does not work in ES6 modules and we might be forced
to be seen as one).

Fixes #6240

@kripken kripken requested a review from tlively February 8, 2024 18:55
@kripken kripken merged commit f09af77 into WebAssembly:main Feb 8, 2024
@kripken kripken deleted the package.json branch February 8, 2024 19:19
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
The JS there is not an ES6 module, so declare it so (otherwise a package.json in a
parent, perhaps in folders outside of our own project that we are pasted in, can
cause an error, as require does not work in ES6 modules and we might be forced
to be seen as one).

Fixes WebAssembly#6240
@gkdn gkdn mentioned this pull request Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Unit tests] ReferenceError: require is not defined in ES module scope

2 participants