[test] Make get_tests return only files #6164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
get_tests
returns files and directories, especially when the extension is not given. This makesget_tests
return a directory liketest/wasm2js/
as a test.wasm2js.py
'scheck_for_stale_files
errors out when there are files withintest/wasm2js/
whose basenames don't match any files within any oftest/
,test/spec/
,test/wasm2js/
.binaryen/scripts/test/wasm2js.py
Lines 33 to 46 in 1d615b3
wasm2js.wast.asserts
is apparently a special case for asserts test:binaryen/scripts/test/wasm2js.py
Line 28 in 1d615b3
wast
tests in the three test directories. But it just happened to not error out becauseget_tests
returns directory names too and one of them waswasm2js
(test/wasm2js/
directory).This makes
get_tests
return only files, and make files inassert_tests
not error out additionally.