Skip to content

Conversation

@tlively
Copy link
Member

@tlively tlively commented Sep 12, 2023

Remove the old forms of ref.test and ref.cast that took heap types instead of
ref types and remove the old array.init_static name for array.new_fixed.

Remove the old forms of ref.test and ref.cast that took heap types instead of
ref types and remove the old array.init_static name for array.new_fixed.
@tlively tlively requested a review from kripken September 12, 2023 00:26
@tlively
Copy link
Member Author

tlively commented Sep 12, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #5929 (cd92415) into main (e9d0fb7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5929      +/-   ##
==========================================
- Coverage   42.60%   42.59%   -0.01%     
==========================================
  Files         484      484              
  Lines       74837    74816      -21     
  Branches    11922    11916       -6     
==========================================
- Hits        31887    31871      -16     
+ Misses      39750    39746       -4     
+ Partials     3200     3199       -1     
Files Changed Coverage Δ
src/gen-s-parser.inc 17.82% <ø> (+<0.01%) ⬆️
src/wasm/wasm-s-parser.cpp 70.42% <100.00%> (-0.15%) ⬇️

... and 2 files with indirect coverage changes

@tlively tlively enabled auto-merge (squash) September 12, 2023 00:43
@tlively tlively merged commit 592f6cc into main Sep 12, 2023
@tlively tlively deleted the remove-legacy-gc-syntax branch September 12, 2023 00:47
radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request Jul 12, 2024
Remove the old forms of ref.test and ref.cast that took heap types instead of
ref types and remove the old array.init_static name for array.new_fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants